[Truffle] add RubyFiletypeDetector #3301
Conversation
|
|
||
| public final class RubyFiletypeDetector extends FileTypeDetector { | ||
|
|
||
| private final static String[] KNOWN_RUBY_FILES = new String[]{ "Gemfile", "Rakefile" }; |
There was a problem hiding this comment.
since we use Mavenfile for some projects (jruby-jars, jruby-openssl, etc) this "might" be another option. but my view of the world is biased :)
|
Ping @jtulach |
|
What is the purpose? |
|
So GraalVM can be given a file with no more information and just run it. |
| if (firstLine.isPresent() && firstLine.get().equals("#!/usr/bin/env ruby")) { | ||
| return RUBY_MIME; | ||
| } | ||
|
|
There was a problem hiding this comment.
Nice, but maybe too strict. What about two spaces in between "env" and "ruby". What if somebody uses just "#!/usr/bin/ruby"...
|
@pitr-ch No Java 8 method ;) |
| final Optional<String> maybeFirstLine = Files.lines(path).findFirst(); | ||
| if (maybeFirstLine.isPresent()) { | ||
| final String firstLine = maybeFirstLine.get(); | ||
| if (firstLine.matches("^#! ?/usr/bin/(env +ruby|ruby).*")) { |
There was a problem hiding this comment.
It's probably best to compile the pattern only once.
pitr-ch
force-pushed
the
master
branch
4 times, most recently
from
4f40dde to
6523b49
Compare
| @@ -0,0 +1,50 @@ | |||
| package org.jruby.truffle; | |||
There was a problem hiding this comment.
I’ve forgot to ask, RubyFiletypeDetector is currently in org.jruby.truffle package, not the best place. What about org.jruby.truffle.runtime.util or other new org.jruby.truffle.util?
There was a problem hiding this comment.
The FiletypeDetector isn't Truffle-only, it might be useful for whole JRuby - so consider option of putting it to generic JRuby runtime.
There was a problem hiding this comment.
Yes org.jruby might be right. And the metadata would then need to go in the core jar obviously.
pitr-ch
force-pushed
the
master
branch
3 times, most recently
from
087e726 to
b8a157e
Compare
No description provided.