LL fix for broken set_c (in fact broken typemap)

PDLPorters · Sep 4, 2015 · a441f34 · a441f34
1 parent e7636f5
commit a441f34
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 8 deletions.
diff --git a/Basic/Core/typemap b/Basic/Core/typemap
@@ -18,13 +18,13 @@ T_PDL_ANYVAL
 		$var.type = -1;
 		$var.value.B = 0;
 	} else if (SvIOK($arg)) {
-#if IVSIZE == 8
+	\#if IVSIZE == 8
 		$var.type = PDL_LL;
 		$var.value.Q = (PDL_LongLong) SvIV($arg);
-#else
+	\#else
 		$var.type = PDL_L;
 		$var.value.L = (PDL_Long) SvIV($arg);
-#endif
+	\#endif
 	} else {
 		$var.type = PDL_D;
 		$var.value.D = (PDL_Double) SvNV($arg);

diff --git a/Basic/Core/typemap.pdl b/Basic/Core/typemap.pdl
@@ -18,13 +18,13 @@ T_PDL_ANYVAL
 		$var.type = -1;
 		$var.value.B = 0;
 	} else if (SvIOK($arg)) {
-#if IVSIZE == 8
+	\#if IVSIZE == 8
 		$var.type = PDL_LL;
 		$var.value.Q = (PDL_LongLong) SvIV($arg);
-#else
+	\#else
 		$var.type = PDL_L;
 		$var.value.L = (PDL_Long) SvIV($arg);
-#endif
+	\#endif
 	} else {
 		$var.type = PDL_D;
 		$var.value.D = (PDL_Double) SvNV($arg);
@@ -36,7 +36,6 @@ T_PDLTRANS
 	else
 	        croak(\"$var is not of type PDL::Trans\");
 
-
 OUTPUT
 
 T_PDL

diff --git a/t/unpdl.t b/t/unpdl.t
@@ -3,7 +3,7 @@ use warnings;
 
 use PDL;
 use Config;
-use Test::More tests => 2;
+use Test::More tests => 7;
 
 my $array = [
  [[1,2],
@@ -47,5 +47,14 @@ SKIP:
        8999999999999999996,
        9223372036854775807, #max int64
   ];
+
   is_deeply(longlong($input)->unpdl, $input, 'back convert of 64bit integers');
+  my $small_pdl = longlong([ -9000000000000000001, 9000000000000000001 ]);
+  is($small_pdl->at(0), -9000000000000000001, 'at/1');
+  is(PDL::Core::at_c($small_pdl, [1]),  9000000000000000001, 'at_c/1');
+  $small_pdl->set(0, -8888888888888888888);
+  PDL::Core::set_c($small_pdl, [1], 8888888888888888888);
+  is($small_pdl->at(0), -8888888888888888888, 'at/2');
+  is(PDL::Core::at_c($small_pdl, [1]),  8888888888888888888, 'at_c/2');
+  is_deeply($small_pdl->unpdl, [ -8888888888888888888, 8888888888888888888 ], 'unpdl/small_pdl');
 }