Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return UTC instead of GMT (fixes #3304) #3310

Merged
merged 1 commit into from
Sep 8, 2015

Conversation

tdaitx
Copy link
Contributor

@tdaitx tdaitx commented Sep 4, 2015

As per Ruby's Time#zone [1] UTC should be used instead of GMT
since Ruby 1.8. The spec also expects UTC.

spec/ruby/core/time/zone_spec.rb:

  it "returns UTC when called on a UTC time" do
    Time.now.utc.zone.should == "UTC"
  end

This also fixes #3304.

[1] http://ruby-doc.org/core-2.2.3/Time.html#method-i-zone

As per Ruby's Time#zone [1] UTC should be used instead of GMT
since Ruby 1.8. This also fixes jruby#3304.

[1] http://ruby-doc.org/core-2.2.3/Time.html#method-i-zone
mkristian added a commit that referenced this pull request Sep 8, 2015
@mkristian mkristian merged commit 0596e57 into jruby:master Sep 8, 2015
@enebo enebo modified the milestone: Non-Release May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zone_spec.rb fails SPEC test "Time#zone returns UTC when called on a UTC time"
3 participants