Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove PDL::GSL::CDF from prereqs #14

Merged
merged 1 commit into from Aug 31, 2015
Merged

remove PDL::GSL::CDF from prereqs #14

merged 1 commit into from Aug 31, 2015

Conversation

zmughal
Copy link
Member

@zmughal zmughal commented Aug 31, 2015

PDL::GSL::CDF is part of PDL-Stats, so having it as a prerequisite causes new installs to fail.

This reverts part of the changes made in #11.

Thanks to @shawnlaffan++ for reporting this at #12.

@zmughal
remove PDL::GSL::CDF from prereqs
91de8e0 
PDL::GSL::CDF is part of PDL-Stats, so having it as a prerequisite
causes new installs to fail.

This reverts part of the changes made in
<#11>.

Thanks to shawnlaffan++ for reporting this at
<#12>.
@zmughal
Copy link
Member Author

zmughal commented Aug 31, 2015

@maggiexyz, @mohawk2: this is a small fix, so a code review shouldn't take long. Could you take a look, please?

@mohawk2
Copy link
Member

mohawk2 commented Aug 31, 2015

Does PDL-S actually dep on PDL::GSL?

@mohawk2 mohawk2 merged commit 91de8e0 into master Aug 31, 2015
@mohawk2 mohawk2 deleted the fix-dep-pdl-gsl-cdf branch August 31, 2015 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zmughal @mohawk2