Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1983 #1998

Merged
merged 4 commits into from Sep 3, 2015
Merged

Fix 1983 #1998

merged 4 commits into from Sep 3, 2015

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Sep 2, 2015

Make tabcompletion work outside sites.

@@ -359,7 +360,7 @@ def run(self, cmd_args):
LOGGER.info('Did you mean "{}" or "{}"?'.format('", "'.join(best_sugg[:-1]), best_sugg[-1]))
return 3

if sub_cmds[args[0]] is not Help and not isinstance(sub_cmds[args[0]], Command): # Is a doit command
if not sub_cmds[args[0]] in (Help, Command, TabCompletion):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won’t work, in won’t catch Command subclasses.

ralsina added a commit that referenced this pull request Sep 3, 2015
@ralsina ralsina merged commit 7be07e8 into master Sep 3, 2015
@ralsina ralsina deleted the fix-1983 branch September 3, 2015 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants