Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Complain when running with an incompatible Graal version. #3311

Closed
wants to merge 1 commit into from

Conversation

eregon
Copy link
Member

@eregon eregon commented Sep 4, 2015

@chrisseaton What should we do?

In the particular case of 0.8, there was no warning before this, and the program would run like on a stock JDK (because truffle is not on the bootclasspath I suppose).

We should probably also make the requirement of Graal 0.7 clearer in the wiki/README.

@eregon eregon added the truffle label Sep 4, 2015
@eregon eregon added this to the truffle-dev milestone Sep 4, 2015
@chrisseaton
Copy link
Contributor

I previously removed this check because the graal.version property was lost in the reorganisation of the repositories but it does need to go back in and this code is fine for that.

@eregon
Copy link
Member Author

eregon commented Sep 6, 2015

@chrisseaton Do you know which commit removed the check (or introduced it)?

@chrisseaton
Copy link
Contributor

It was removed in cad8f5e.

@eregon eregon closed this in 04cf44a Sep 7, 2015
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants