[Truffle] Complain when running with an incompatible Graal version. #3311
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I previously removed this check because the graal.version property was lost in the reorganisation of the repositories but it does need to go back in and this code is fine for that. |
|
@chrisseaton Do you know which commit removed the check (or introduced it)? |
|
It was removed in cad8f5e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chrisseaton What should we do?
In the particular case of 0.8, there was no warning before this, and the program would run like on a stock JDK (because truffle is not on the bootclasspath I suppose).
We should probably also make the requirement of Graal 0.7 clearer in the wiki/README.