This repository was archived by the owner on Mar 10, 2020. It is now read-only.
autoconfigure in browser #51
Merged
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| // autoconfigure in browser | ||
| if (!config.host && | ||
| window && window.location) { | ||
| var split = window.location.host.split(':') |
There was a problem hiding this comment.
This looks like it works when the ipfsAPI is used from a domain:port url only. Do we want to use the url of the web application where the domain is being loaded for this?
There was a problem hiding this comment.
'gateway.ipfs.io'.split(':') -> ['gateway.ipfs.io']
|
Left out the port 80, tested localy and in gateway. if port is |
|
@krl LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If host is unset, and we're in the browser, use the window.location.host to auto-configure the api.