Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Alpine Linux #3493

Closed
wants to merge 3 commits into from
Closed

Fixes for Alpine Linux #3493

wants to merge 3 commits into from

Conversation

CpuID
Copy link
Contributor

@CpuID CpuID commented Aug 27, 2015

Discussion at #3492

@yorickpeterse
Copy link
Contributor

Only noticed this now, sorry. My only request is to provide a somewhat more meaningful commit message, "fixes so far" doesn't indicate anything about what is actually being fixed. Other than that this PR looks good to me.

@CpuID
Copy link
Contributor Author

CpuID commented Oct 4, 2015

@yorickpeterse kind of got it, but that pesky https://github.com/CpuID/rubinius/commit/9dd3f47c6f540ce41053da5478abbfcedd87a5aa is still laying around in the branch... :(

@yorickpeterse
Copy link
Contributor

@CpuID A rebase should do it, alternatively I can rebase it prior to merging if that's easier.

@CpuID
Copy link
Contributor Author

CpuID commented Oct 4, 2015

yes please, if you can that would be awesome :)

@yorickpeterse
Copy link
Contributor

Rebased into 2920c9e, thanks!

@CpuID CpuID deleted the fixes_for_alpine_linux branch October 4, 2015 23:56
@brixen
Copy link
Member

brixen commented Jan 25, 2018

@CpuID thanks to you and everyone who worked on this. I just built 3.95 on Alpine 3.7 Docker image:

/rubinius # bin/rbx -v
rubinius 3.95 (2.3.1 b71836bd 2018-01-25 5.0.0) [x86_64-linux-gnu]
/rubinius # cat /etc/issue
Welcome to Alpine Linux 3.7
Kernel \r on an \m (\l)

/rubinius # uname -a
Linux 11a544638b51 4.9.75-linuxkit-aufs #1 SMP Tue Jan 9 10:58:17 UTC 2018 x86_64 Linux
/rubinius # bin/rbx -S gem list

*** LOCAL GEMS ***

bundler (1.11.2)
minitest (5.11.1)
racc (1.4.14)
rake (12.3.0)
rb-readline (0.5.5)
rdoc (5.1.0)

I'm working on a new build pipeline for Rubinius binaries and I'll add Alpine to it.

@brixen
Copy link
Member

brixen commented Jan 25, 2018

Chicken-scratch notes that need to be turned into a build script https://gist.github.com/brixen/ef849d23078ee3fc617c7f40ad3630bf

@CpuID
Copy link
Contributor Author

CpuID commented Jan 25, 2018

@CpuID thanks to you and everyone who worked on this.

yw :) thanks for sorting it out in the standard version 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants