-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Alpine Linux #3493
Fixes for Alpine Linux #3493
Conversation
Only noticed this now, sorry. My only request is to provide a somewhat more meaningful commit message, "fixes so far" doesn't indicate anything about what is actually being fixed. Other than that this PR looks good to me. |
… 100% building yet, but these cover some outstanding issues
…to fixes_for_alpine_linux
@yorickpeterse kind of got it, but that pesky https://github.com/CpuID/rubinius/commit/9dd3f47c6f540ce41053da5478abbfcedd87a5aa is still laying around in the branch... :( |
@CpuID A rebase should do it, alternatively I can rebase it prior to merging if that's easier. |
yes please, if you can that would be awesome :) |
Rebased into 2920c9e, thanks! |
@CpuID thanks to you and everyone who worked on this. I just built 3.95 on Alpine 3.7 Docker image:
I'm working on a new build pipeline for Rubinius binaries and I'll add Alpine to it. |
Chicken-scratch notes that need to be turned into a build script https://gist.github.com/brixen/ef849d23078ee3fc617c7f40ad3630bf |
yw :) thanks for sorting it out in the standard version 👍 |
Discussion at #3492