Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile requires PDL::GSL::CDF, which is not indexed on CPAN #12

Closed
shawnlaffan opened this issue Aug 31, 2015 · 5 comments
Closed

makefile requires PDL::GSL::CDF, which is not indexed on CPAN #12

shawnlaffan opened this issue Aug 31, 2015 · 5 comments

Comments

@shawnlaffan
Copy link

Just tried installing PDL::Stats on a perlbrew install, and received the error Couldn't find module or a distribution PDL::GSL::CDF

The makefile requires PDL::GSL::CDF in the PREREQ_PM, BUILD_REQUIRES and TEST_REQUIRES sections, but it is not indexed on cpan.

Installation works after commenting the PDL::GSL::CDF lines.

PDL::GSL::CDF seems to be part of PDL::Stats, albeit an optional component. It is also listed in the documentation below the comment # and the following if installed;

Regards,
Shawn.

@zmughal
Copy link
Member

zmughal commented Aug 31, 2015

Thanks for catching this, @shawnlaffan. I'll make a patch and new release soon.

@mohawk2, it appears that #11 should not have listed PDL::GSL::CDF. PDL::GSL::CDF is part of PDL-Stats in https://github.com/PDLPorters/PDL-Stats/tree/master/GSL.

zmughal added a commit that referenced this issue Aug 31, 2015
PDL::GSL::CDF is part of PDL-Stats, so having it as a prerequisite
causes new installs to fail.

This reverts part of the changes made in
<#11>.

Thanks to shawnlaffan++ for reporting this at
<#12>.
@mohawk2
Copy link
Member

mohawk2 commented Aug 31, 2015

Good catch! Merged. New release out shortly. Will also be reflected on PDLA::Stats, which I recommend you switch to.

@mohawk2 mohawk2 closed this as completed Aug 31, 2015
zmughal added a commit to PDLPorters/pdla-stats that referenced this issue Aug 31, 2015
PDL::GSL::CDF is part of PDL-Stats, so having it as a prerequisite
causes new installs to fail.

This reverts part of the changes made in
<PDLPorters/PDL-Stats#11>.

Thanks to shawnlaffan++ for reporting this at
<PDLPorters/PDL-Stats#12>.
@maggiexyz
Copy link
Contributor

Yes PDL::GSL::CDF is provided in PDL::Stats. PDL::Stats will install and use it if the gsl c lib is available. The module is under PDL::GSL namespace because there're already other PDL::GSL modules in PDL. At one point there were talks about moving PDL::GSL::CDF to be with all other PDL::GSL modules but it never quite happened. I'm happy with moving PDL::GSL::CDF over if other people see fit.

@mohawk2
Copy link
Member

mohawk2 commented Aug 31, 2015

The direction I see things moving in (because I'm moving them that way) is towards smaller bundles, not larger ones.

@maggiexyz Have you seen https://github.com/PDLPorters/pdla-stats ?

@maggiexyz
Copy link
Contributor

That's fine. I'm also happy to continue providing PDL::GSL::CDF in PDL::Stats. Just looked at pdla-stats. It's weird that while the kmeans tests aren't deterministic, it's only cc=clang that keeps failing. I'll need some time to dig into the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants