New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 0.1 version of import_goodreads #105
Conversation
Example of output: http://www.juanjoconti.com/tags/goodreads-review.html |
I thought of the idea (and I was going to open an issue) of having a generic import plugin from which this and other plugins can extend. It would not go away, just be refactored. |
There is one, it's called |
needs_config = False | ||
doc_usage = "[options] rss_url" | ||
doc_purpose = "import a Goodreads RSS" | ||
cmd_options = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ImportMixin already has cmd_options so you don't need to repeat them here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I repeated it because I wanted to change the default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably don't want to default to "posts"... it will try to see if there's a "posts/conf.py" and do crazy stuff.
os.path.join(self.output_folder, slug + '.html'), | ||
content) | ||
|
||
@staticmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you change post_date a few lines before, then you don't need this method at all
|
||
It: | ||
|
||
* users the date the user ends to read the book as post date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/users/uses/
Add 0.1 version of import_goodreads
for item in channel.entries: | ||
self.process_item(item) | ||
|
||
def process_item(self, item): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you move the if into import_posts you don't need to reimplement process_item
No description provided.