Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 78f709d0d431
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: f9b7714b4b3f
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Aug 9, 2013

  1. test: use common.PORT in simple/test-net-GH-5504

    @bnoordhuis
    bnoordhuis committed Aug 9, 2013
    Copy the full SHA
    f548433 View commit details
    Browse the repository at this point in the history

  2. src: don't call v8::Object::SetHiddenValue() 

    Don't use v8::Object::SetHiddenValue() to keep a reference alive to the
buffer, we can just as easily do that from JS land and it's a lot faster
to boot.

Because the buffer is now a visible property of the write request
object, it's essential that we do *not* log it - we'd be effectively
serializing the whole buffer to a pretty-printed string.
    @bnoordhuis
    bnoordhuis committed Aug 9, 2013
    Copy the full SHA
    f9b7714 View commit details
    Browse the repository at this point in the history