[Ruby 2.3] Concurrency improvements to Queue/SizedQueue #3553
+477
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation is now based on Doug Lea’s LinkedBlockingQueue. Concurrency wise, this is now dual locked (head/tail) linked queue, since Ruby std lib queues have blocking operations a completely lock-free queue is not practical endeavor.
|
Very nice! I had similar code at various times in the past week and kept getting pulled away. I also based mine on Doug's |
headius
added a commit
that referenced
this pull request
Dec 28, 2015
[Ruby 2.3] Concurrency improvements to Queue/SizedQueue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The implementation is now based on Doug Lea’s
LinkedBlockingQueue.Concurrency wise, this is now dual locked (head/tail) linked queue,
since Ruby std lib queues have blocking operations a completely
lock-free queue is not practical endeavor.