[Truffle] Antlr printf #3551
Merged
[Truffle] Antlr printf #3551
+406
−434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # truffle/src/main/java/org/jruby/truffle/format/parser/FormatParser.java # truffle/src/main/java/org/jruby/truffle/format/parser/FormatTokenizer.java
| @@ -1947,11 +1947,11 @@ public Long block() throws InterruptedException { | |||
|
|
|||
| @CoreMethod(names = { "format", "sprintf" }, isModuleFunction = true, rest = true, required = 1, taintFromParameter = 0) | |||
| @ImportStatic(StringCachingGuards.class) | |||
| public abstract static class FormatNode extends CoreMethodArrayArgumentsNode { | |||
| public abstract static class XFormatNode extends CoreMethodArrayArgumentsNode { | |||
There was a problem hiding this comment.
The renaming was a debugging thing. I'll use sprintf.
|
Looks good, there is still quite a bit of logic with switches in the TreeBuilder but it seems hard to avoid. |
| public class PrintfTreeBuilder extends org.jruby.truffle.format.parser.PrintfParserBaseListener { | ||
|
|
||
| // TODO CS 19-Dec-15 this is never used, but the functionality seems useful | ||
| public static final int PADDING_FROM_ARGUMENT = -2; |
There was a problem hiding this comment.
Accidentally deleted a comment from Benoit here saying it's using in Time.httpdate and that there should be a spec for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.