fsrepo: Allow for custom datastore path #2121
Closed
+79
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives the user the option to set a `datastore` flag to change where the leveldb and flatfs database live.
|
There were the following issues with your Pull Request
Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue. This message was auto-generated by https://gitcop.com |
|
|
||
| } | ||
|
|
||
| if !util.FileExists(leveldbPath) { |
There was a problem hiding this comment.
Should there also be a check for the flatfs directory during all this initialization?
|
So this changed the paths a bit Previous Now: So ya, going to have to rework a few things and clean this up. Not the simple pipe through I was hoping for. |
|
I'm going to fix this up more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives the user the option to set a
datastoreflag to change where the leveldb and flatfs database live.Addresses #2117
I might rewrite this a bit to change the fsrepo checking and such around to better suit this option. This is slightly hacked together due to the way the original code was written. It made it hard to pipe through a few things. Some functions might need to be rewritten. I'm mostly not too keen on the random blank strings and passing nil around when the config doesn't exist yet.