Update raising of WaitReadable/WaitWritable exceptions #3541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 25, 2015 17:24
IO#read_nonblock is supposed to raise IO::EAGAINWaitReadable instead of a regular Errno::EAGAIN error.
This tests for IO#write_nonblock raising IO::EAGAINWaitWritable when an operation would block (instead of just raising Errno::EAGAIN).
IO#read_nonblock should raise IO::EAGAINWaitReadable (or IO::EWOULDBLOCKWaitReadable) while IO#write_nonblock should raise IO::EAGAINWaitWritable (or IO::EWOULDBLOCKWaitWritable).
These will be used by rubysl-socket for connecting a socket in a non-blocking manner.
| @@ -727,7 +727,7 @@ namespace rubinius { | |||
| int res = ::select(fd+1, &set, 0, 0, &tv); | |||
|
|
|||
| if(res == 0) { | |||
| Exception::errno_eagain_error(state, "no data ready"); | |||
| Exception::errno_wait_readable(state, EAGAIN); | |||
There was a problem hiding this comment.
This is a bit of a hack because errno is not set when select returns 0. Without explicitly passing EAGAIN we'd have to handle this case in Exception::errno_wait_readable which I think is the wrong place to do so (since this behaviour is very specific to select).
brixen
added a commit
that referenced
this pull request
Dec 25, 2015
Update raising of WaitReadable/WaitWritable exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
IO#read_nonblockandIO#write_nonblockto raise the correct exceptions (using somewhat more flexible code) as well as defining extraWaitReadable/WaitWritableexception classes to be used by rubysl-socket.