Skip to content

Commit

Permalink
Verify node type is facedir.
Browse files Browse the repository at this point in the history
This prevents nodes that are not of the "facedir" paramtype2,
as these are generally not expected to be able to rotate. Mods
and other methods may still manipulate param2 of these nodes
as expected.

Addresses #712
  • Loading branch information
sofar authored and paramat committed Dec 25, 2015
1 parent b1e2ece commit 82299b9
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions mods/screwdriver/init.lua
Expand Up @@ -35,6 +35,10 @@ local function screwdriver_handler(itemstack, user, pointed_thing, mode)

local node = minetest.get_node(pos)
local ndef = minetest.registered_nodes[node.name]
-- verify node is facedir (expected to be rotatable)
if ndef.paramtype2 ~= "facedir" then
return
end
-- Compute param2
local rotationPart = node.param2 % 32 -- get first 4 bits
local preservePart = node.param2 - rotationPart
Expand Down

0 comments on commit 82299b9

Please sign in to comment.