[Truffle] Upgraded from Rubinius 2.5.6 to 2.7. #3561
Merged
+146
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the biggest things of note are:
|
|
Seems quite straightforward, looks good. |
| class Time | ||
|
|
||
| def to_f | ||
| seconds + nsec * 0.000000001 # Truffle: optimized |
There was a problem hiding this comment.
'optimized'? What is this for?
There was a problem hiding this comment.
I think #to_f was using rational, which went off into the weeds doing some crazy stuff.
There was a problem hiding this comment.
Yeah it's optimized to avoid going down a crazy path when we know our precision is limited.
Thank you for moving it to a shim Kevin!
|
Looks good. |
nirvdrum
added a commit
that referenced
this pull request
Dec 23, 2015
[Truffle] Upgraded from Rubinius 2.5.6 to 2.7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly straightforward upgrade from Rubinius 2.5.6 to 2.7. I copied over code formatting changes made upstream to avoid future diffs the next time we sync. There was some additional whitespace that looks odd, but it's what upstream has.
@chrisseaton @pitr-ch @eregon - Please give a look over at your leisure.