Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 809812c425f1
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4f9e6bec6813
Choose a head ref
  • 9 commits
  • 11 files changed
  • 1 contributor

Commits on Dec 23, 2015

  1. review code and esp. exception handling in socket classes (make sure … 

    …no more surprises)

* added socketerr helper - to wrap cause in some generic exception handling cases
* commented out catching Error (due a Java 1.5 work-around)
* some internal private methods refactored
    @kares
    kares committed Dec 23, 2015
    Copy the full SHA
    5f7c7b6 View commit details

  2. RubyIO code review - avoid redundant casts & deprecated methods + get… 

    …Runtime()
    @kares
    kares committed Dec 23, 2015
    Copy the full SHA
    792d316 View commit details

  3. [test] avoid polluting with a WINDOWS constant + require timeout wher… 

    …e needed
    @kares
    kares committed Dec 23, 2015
    Copy the full SHA
    403ca96 View commit details

  4. handle UDP socket bind "permission denied" errors as EACCES (like MRI)

    @kares
    kares committed Dec 23, 2015
    Copy the full SHA
    bdcc08e View commit details

  5. match-up TCP socket ECONNREFUSED message more closely to MRI

    @kares
    kares committed Dec 23, 2015
    Copy the full SHA
    7545673 View commit details

  6. allow running some of tests under MRI - test_helper should load fine

    @kares
    kares committed Dec 23, 2015
    Copy the full SHA
    0d51ff3 View commit details

  7. handleSocketException can go static itself

    @kares
    kares committed Dec 23, 2015
    Copy the full SHA
    a71ad55 View commit details

  8. untag passing Socket tests

    @kares
    kares committed Dec 23, 2015
    Copy the full SHA
    78d1dcd View commit details

  9. adjust socket exception handling to act more compatibly with MRI's er… 

    …rors
    @kares
    kares committed Dec 23, 2015
    Copy the full SHA
    4f9e6be View commit details
Loading