port NonBlockingHashMapLong from high-scale-lib #3560
Merged
+1,571
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… high_scale's this is to support envs that do not have sun.misc.Unsafe (such as Android)
... hopefully this won't have much effect on map's performance
kares
changed the title
|
if this looks like a good "resolution" please review the CAS fall-back semantics for arrays such as : 1624fd4#diff-0658ae080e35e981bf3e13528f2730c1R1398 ... if there's anything to be done better |
|
I'm just reviewing PS: other potential reviewers: Cliff's cas isn't on the same volatile field that is used for read side sychronizes-with order. PS2: admittedly, compared to |
|
Looks ok to me on a quick read-through, and I have faith in @thedarkone's judgment. Merging. |
headius
added a commit
that referenced
this pull request
Dec 28, 2015
port NonBlockingHashMapLong from high-scale-lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the high-scale lib has been added as a dependency fairly recently on 9K as well as 1.7.23
it was introduced to use
NonBlockingHashMapLongas an alternative ofIntHashMap(due #3394)turns out that the library can not work without
Unsafe(and thus broke Android support in 1.7.x see #3554) while JRuby allows to boot and run whensun.misc.Unsafeis not available. thus the proposal here is to port theNonBlockingHashMapLongover (the com.boundary:hish-scale-lib received no commit in more than a year) and tune it to be usable withoutUnsafe(fixing #3554)this also resolves #3555 - packaging issue as .jar includes patch(es) of JDK class(es)