Use a custom shortcode parser #2194
Conversation
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
| # Space inside unquoted name: save as positional argument | ||
| args.append(cname) | ||
| cname = cvalue = qc = '' | ||
| elif char == ' ' and flag == 1: |
There was a problem hiding this comment.
If you use binary notation above, why not here (and in the following cases) as well?
There was a problem hiding this comment.
I’ll drop the binary notation then; it felt more readable to me in this case.
There was a problem hiding this comment.
Why not use binary notation everywhere? That makes it more readable for everyone!
There was a problem hiding this comment.
A bit too much cruft for me. If you really want that, you can make everything binary.
|
LGTM |
| if flag & 0b100 and flag & 1: | ||
| # Backslash in value: escape next character, no matter what | ||
| cvalue += char | ||
| flag -= 0b100 |
There was a problem hiding this comment.
Why do you use + and - for bit operations instead of &, | and ~?
There was a problem hiding this comment.
Because I was too lazy to come up with the bitwise operations needed, and because ± is good enough for this case. Fixed on master.
This replaces the cheat involving the HTML parser with a custom character-based parser, written in pure Python.
Advantages:
Disadvantages: