Merged the last bits of cdk-annotation into cdk-ioformats #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Argh... local Maven repository cache... I'm fixing the Travis-CI compile fail... |
|
Unfortunately for compatibility the core/annotation/pom.xml needs to stay in place as an empty module. No deprecation mechanism in maven and if this module is used directly downstream (admittedly unlikely here) it would be confusing why the build fails. It doesn't need to stay where it is though, hence we could put old/empty modules under a subdir. |
|
Mmm... what does an empty pom.xml file look like? Just the name, artifactId, etc, but no plugins and no , etc? |
egonw
force-pushed
the
patch/dataFeaturesInIOFormats
branch
from
9b188a9
to
2c4b04e
Compare
|
ping @johnmay, I have restored the annotation pom.xml and rebased this patch on the latest master. |
johnmay
added a commit
that referenced
this pull request
Jan 7, 2016
Merged the last bits of cdk-annotation into cdk-ioformats
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.