Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/remove old constants #186

Merged
merged 1 commit into from Dec 28, 2015
Merged

Conversation

egonw
Copy link
Member

@egonw egonw commented Dec 27, 2015

Removed unused constants and use IBond.Order directly.

@johnmay
Copy link
Member

johnmay commented Dec 28, 2015

API change... please deprecate instead of remove.

@egonw
Copy link
Member Author

egonw commented Dec 28, 2015

[API change] Ah, fair point... I will update this patch. (still used to the past situation where this was allowed in the development branch ;)

@egonw
Copy link
Member Author

egonw commented Dec 28, 2015

@johnmay I've updated the patch:

  • use @depecated
  • undid the removal of the hybridization fields

@johnmay
Copy link
Member

johnmay commented Dec 28, 2015

Looks good

@johnmay johnmay closed this Dec 28, 2015
@johnmay johnmay reopened this Dec 28, 2015
johnmay added a commit that referenced this pull request Dec 28, 2015
@johnmay johnmay merged commit 591b21d into cdk:master Dec 28, 2015
@egonw egonw deleted the patch/removeOldConstants branch September 27, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants