Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: baecd42ad467
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9ba2d0a37a40
Choose a head ref
  • 9 commits
  • 2 files changed
  • 1 contributor

Commits on Dec 28, 2015

  1. cleanup StringIO - unnecessary casts, unused initial local variable v… 

    …alue
    @kares
    kares committed Dec 28, 2015
    Copy the full SHA
    1917af2 View commit details

  2. remove unused private makeString + dry out last-arg limit: 0 checking

    @kares
    kares committed Dec 28, 2015
    Copy the full SHA
    038bbc9 View commit details

  3. avoid initial local assingment not-used

    @kares
    kares committed Dec 28, 2015
    Copy the full SHA
    0eda51e View commit details

  4. avoid potential string index out of bounds exception

    @kares
    kares committed Dec 28, 2015
    Copy the full SHA
    02cd745 View commit details

  5. adjust close_read & close_write to behave like MRI 2.3 does 

    ... now passing test_close_read and test_close_write tests
    @kares
    kares committed Dec 28, 2015
    Copy the full SHA
    b6d2903 View commit details

  6. rename added checkLastArg0 helper as it does not throw like other che… 

    …ck methods do

also cleanup getRuntime() + too much (RubyString) casting - use another local instead
    @kares
    kares committed Dec 28, 2015
    Copy the full SHA
    e4cd629 View commit details

  7. repeated StringIO#close is not expected to raise (in Ruby 2.3)

    @kares
    kares committed Dec 28, 2015
    Copy the full SHA
    3b33f8e View commit details

  8. StringIO#read_nonblock requires 1 argument

    @kares
    kares committed Dec 28, 2015
    Copy the full SHA
    90653ee View commit details

  9. StringIO has its own encoding (string's enc on set_encoding only set … 

    …when writable)

port of https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/53188
    @kares
    kares committed Dec 28, 2015
    Copy the full SHA
    9ba2d0a View commit details
Showing with 165 additions and 155 deletions.
  1. +165 −154 core/src/main/java/org/jruby/ext/stringio/StringIO.java
  2. +0 −1 test/mri/excludes/TestStringIO.rb
Loading