Adding support for auth_tag for GCM based crypto [WIP] #75
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, seems good. I believe a passing test or two could make this merge material ... |
|
@kares Sure I can clean this up! So GCMParameterSpec was only added in java 7. Do you want me to check for its presence and use if available otherwise keep using Iv? |
|
you can try to make this work in Java 7+ only and we're worry about making it Java 6 compatible later ... |
|
@kares If I am reading the travis output right build passed on all openjdk7+ |
|
Closing the pr till we can get an end to end test working (doesnt seem to be working atm) jruby encrypted mri decrypted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is far from mergable but it gives us enough to keep going with our migration from mri to jruby.
The issue is java 8 does not support using an IvParameterSpec with GCM as can be seen in this bug. SANTUARIO-392 so we added a conditional block to use the gcm spec object. Additionally, ruby 2 cipher supports getting ahold of the auth_tag but only after you call final, which we needed for our use case.