Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDL::GSL::CDF facelift #21

Merged
merged 1 commit into from Oct 20, 2015
Merged

PDL::GSL::CDF facelift #21

merged 1 commit into from Oct 20, 2015

Conversation

kmx
Copy link
Contributor

@kmx kmx commented Oct 18, 2015

Couple of improvements:

  1. The previous version was missing all gsl_cdf_*_Q and gsl_cdf_*_Qinv functions (which was IMO a bug in regexp picking up the functions from GSL header). My patch adds these functions.
  2. Test suite was extended so that it tests every single function included in PDL::GSL::CDF
  3. Documentation was slightly improved, now it looks like this https://gist.github.com/kmx/cd397ca38e2469bbf440
  4. Should be 100% backwards compatible

I hope you find it useful.

--kmx

@kmx
Copy link
Contributor Author

kmx commented Oct 19, 2015

Travis CI failure by this pull request is IMO crashing t/kmeans.t see issue #19

@maggiexyz
Copy link
Contributor

Muchas gracias! I just merged the kmeans fix. Is there a way to re-run the Travic CI tests with this pull request?

@kmx
Copy link
Contributor Author

kmx commented Oct 20, 2015 via email

maggiexyz added a commit that referenced this pull request Oct 20, 2015
@maggiexyz maggiexyz merged commit 15ed78e into PDLPorters:master Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants