-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Truffle] jruby+truffle - rspec broken? #3374
Comments
I think this might be a recent bug introduced by some changes @eregon made to declaration scopes - the method in question is declared in a Proc, so the object it's supposed to attach itself to could well be wrong. https://github.com/rspec/rspec-core/blob/master/lib/rspec/core/shared_example_group.rb#L104 @eregon could you take a look, please? |
Fixed, it was a bug of the |
Thanks very much! |
Thanks for the fix! Specs run now, but somehow not fully/looks like it silently aborts at some point:
The same thing happens with different subsets of specs though, so it doesn't seem to choke on a special spec or something like that. |
It seems due to our Kernel#exit doing a hard exit instead of raising an exception. |
@eregon 👍 thanks! Weird that it still triggered when I ran the mcts subset but great :) |
Hey everyone,
I'm trying to run my rspec specs with truffle as @chrisseaton showed me -it might well be that I have a local setup fault over here.
jruby+truffle
seems to work fine:It even runs my benchmarks fine ( 👍 ) however when trying to run my specs or even a bare spec file then it breaks:
I pulled and built JRuby today:
So yeah, is this a recent regression or is my setup wrong?
Thanks + cheers,
Tobi
The text was updated successfully, but these errors were encountered: