Skip to content

Commit

Permalink
Remove converting to negative fd
Browse files Browse the repository at this point in the history
Convert a fd to -(fd + 1) if its a Fixnum seems wrong.
Negative fds's are mostly invalid.
  • Loading branch information
tak1n committed Oct 10, 2015
1 parent c1f479d commit c8ce8a7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
1 change: 0 additions & 1 deletion kernel/common/process_mirror.rb
Expand Up @@ -186,7 +186,6 @@ def convert_to_fd(obj, target)
when 2
if obj[0] == :child
fd = convert_to_fd obj[1], target
fd.kind_of?(::Fixnum) ? -(fd + 1) : fd
else
[obj[0], convert_file_mode(obj[1]), 0644]
end
Expand Down
10 changes: 0 additions & 10 deletions spec/tags/ruby/core/io/popen_tags.txt

This file was deleted.

0 comments on commit c8ce8a7

Please sign in to comment.