refactor dialing to not panic, and to be smart about ordering #1837
+48
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -371,87 +373,84 @@ func (s *Swarm) dialAddrs(ctx context.Context, d *conn.Dialer, p peer.ID, remote | |||
| ctx, cancel := context.WithCancel(ctx) | |||
| defer cancel() // cancel work when we exit func | |||
|
|
|||
| foundConn := make(chan struct{}) | |||
| conns := make(chan conn.Conn, len(remoteAddrs)) | |||
| conns := make(chan conn.Conn) | |||
There was a problem hiding this comment.
if this gets buffered, then open connections just sit in the channel and never get closed
|
weird, not sure why the goproc limiter has a bug. also this is not a goprocess bug it's a goprocess/limiter bug-- it's UX is bad. (we can change the goprocess interface to not panic on this sort of thing, and instead close the process immediately.) |
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
dial-smarter
branch
from
868d5f0 to
663a030
Compare
|
alright, stripped this PR down to just the panic fix simplification stuff. |
|
huh, maybe I should fix this one too: https://travis-ci.org/ipfs/go-ipfs/jobs/85398391 Since it decided to fail on this PR of any it could have chosen |
|
@whyrusleeping ok sounds good. |
jbenet
added a commit
that referenced
this pull request
Oct 16, 2015
refactor dialing to not panic, and to be smart about ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After yet another goprocess bug I decided to just rip it out. Its gone now. bye bye.
I also figured that, while I was at it, I would add a bit of priority to the order in which we dial addresses.
First: addresses that dont consume a file descriptor.
Second: localhost addresses, as they should either succeed or fail immediately.
Third: all normal tcp addresses.
Last: dockers '172.17' range of addresses, these are almost always trouble.
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com