-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: 2.2 compat #3518
Merged
Merged
WIP: 2.2 compat #3518
+1,386
−332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ruby 2.2+, we have #receiver, so it makes sense to use consistent names here and and get rid of #self and #self= in favor of #receiver and #receiver=
These were lost by accident while resolving merge conflicts between the master branch and the 2.2 branch.
This commit fixes a build error due to a signature mismatch of the Time::at method and the way it was being used in Stat::stat_birthtime.
The implementation relies on Module#direct_superclass to run through the whole ancestry chain as #superclass would not include the modules. The method is about 2 times slower than the MRI implementation though. Benchmark: http://git.io/vmhpf.
Based on commit ruby/ruby@b4981594.
Interesting enough MRI still lets you define methods on these objects even when they're frozen. For example, this works just fine: def nil.foo end nil.foo
* master: Fixes to assist building Rubinius under Alpine Linux (with musl). Changed "of the issue" to "if the issue" Contributing notes on version managers/releases Expand $PID in Metrics filename. Clean up log output of serial_debug/ic_debug Specify `superclass` in respect to `prepend` Fix correction to documentation for OnStack class. Fixed typ in the OnStack class Log class names for invalid ivars_ references Add a C-API "rb_hash_clear" Fix Range#bsearch for matching end value in find-minimum mode Fix String#split with 0 limit. Fixes #3474 Add a String#split spec with 0 limit
Convert a fd to -(fd + 1) if its a Fixnum seems wrong. Negative fds's are mostly invalid.
* 2.2: allow nil,true,false to be modified when frozen
Check for st_atim, st_mtim, st_ctim, etc. in struct stat (sys/stat.h)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just opening this PR to let it run through travis.
Our 2.2 branch is not recognized.