improve Mojo::DOM::CSS to support selectors with leading and trailing…

… whitespace
mojolicious · Oct 15, 2015 · dca86b8 · dca86b8
1 parent c99ece3
commit dca86b8
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,7 @@
 
-6.25  2015-10-14
+6.25  2015-10-15
+  - Improved Mojo::DOM::CSS to support selectors with leading and trailing
+    whitespace.
   - Fixed "0" value bug in Mojo::JSON::Pointer.
 
 6.24  2015-10-13

diff --git a/lib/Mojo/DOM/CSS.pm b/lib/Mojo/DOM/CSS.pm
@@ -1,6 +1,8 @@
 package Mojo::DOM::CSS;
 use Mojo::Base -base;
 
+use Mojo::Util 'trim';
+
 has 'tree';
 
 my $ESCAPE_RE = qr/\\[^0-9a-fA-F]|\\[0-9a-fA-F]{1,6}/;
@@ -72,7 +74,7 @@ sub _combinator {
 }
 
 sub _compile {
-  my $css = "$_[0]";
+  my $css = trim "$_[0]";
 
   my $group = [[]];
   while (my $selectors = $group->[-1]) {

diff --git a/t/mojo/dom.t b/t/mojo/dom.t
@@ -2432,6 +2432,11 @@ is $dom->at('span + b')->text, 'b', 'right text';
 is $dom->at('b + span')->text, 'c', 'right text';
 is "$dom", '<span>a</span><b>b</b><span>c</span>', 'right result';
 
+# Selectors with leading and trailing whitespace
+$dom = Mojo::DOM->new('<div id=foo><b>works</b></div>');
+is $dom->at(' div   b ')->text,          'works', 'right text';
+is $dom->at('  :not(  #foo  )  ')->text, 'works', 'right text';
+
 # "0"
 $dom = Mojo::DOM->new('0');
 is "$dom", '0', 'right result';