Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new camel serialization tool #65

Closed
wants to merge 6 commits into from

Conversation

bseeger
Copy link
Contributor

@bseeger bseeger commented Nov 24, 2015

Here's the new camel serialization tool.

https://jira.duraspace.org/browse/FCREPO-1519

</portNames>
</configuration>
<executions>
<execution>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to add an ID to this execution. See here for an example: https://github.com/fcrepo4-exts/fcrepo-camel-toolbox/blob/master/fcrepo-indexing-triplestore/pom.xml#L138-L153

Without it, the build (mvn clean install) will fail: https://travis-ci.org/fcrepo4-exts/fcrepo-camel-toolbox/builds/93045316

@ajs6f
Copy link
Contributor

ajs6f commented Nov 25, 2015

I'm confused now about how the various configs work (the config in Blueprint, the config in *.cfg). Can you document that a bit in-line?


private static Map<String,Object> createRemoveEvent() {

final Map<String, Object> headers = new HashMap<>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just use ImmutableMap::of.

@bseeger
Copy link
Contributor Author

bseeger commented Dec 2, 2015

I changed/fixed the code based on all of the above suggestions. Thanks, guys!

The JMS connection URI, used as a default input stream (queue).

jms.brokerUrl=tcp://localhost:61616

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be really nice to include the configuration properties in the README file. Basically anything in the ./src/main/cfg/*.cfg file should be documented here.

@awoods
Copy link

awoods commented Dec 13, 2015

Resolved with: 4198ccc

@awoods awoods closed this Dec 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants