New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new camel serialization tool #65
Conversation
</portNames> | ||
</configuration> | ||
<executions> | ||
<execution> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be sure to add an ID to this execution. See here for an example: https://github.com/fcrepo4-exts/fcrepo-camel-toolbox/blob/master/fcrepo-indexing-triplestore/pom.xml#L138-L153
Without it, the build (mvn clean install
) will fail: https://travis-ci.org/fcrepo4-exts/fcrepo-camel-toolbox/builds/93045316
I'm confused now about how the various configs work (the config in Blueprint, the config in |
|
||
private static Map<String,Object> createRemoveEvent() { | ||
|
||
final Map<String, Object> headers = new HashMap<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just use ImmutableMap::of
.
I changed/fixed the code based on all of the above suggestions. Thanks, guys! |
The JMS connection URI, used as a default input stream (queue). | ||
|
||
jms.brokerUrl=tcp://localhost:61616 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be really nice to include the configuration properties in the README file. Basically anything in the ./src/main/cfg/*.cfg
file should be documented here.
Resolved with: 4198ccc |
Here's the new camel serialization tool.
https://jira.duraspace.org/browse/FCREPO-1519