-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asciidoctorj-pdf does not work with JRuby 1.7.23 #3496
Comments
It looks like it is resolving the path incorrectly, as indicated by this segment in the file name:
|
the same script works with jruby-9.0.4.0 and when jruby picks a locally install gem then it fails a little later:
same |
this is also a jruby-9k bug. but it does not show for the reason I stated above. |
@robertpanzer @mojavelinux I am about to push a fix for this. would like to verify it work with asciidoctorj or actually would like to verify that the current 1.7.24-SNAPSHOT works with asciidoctorj. how can run its testsuite ? do the tests cover this bug here ? |
anyways pushed the fix to https://oss.sonatype.org/content/repositories/snapshots/ for jruby-1.7.24-SNAPSHOT |
You should be able to test by downloading the distribution asciidoctorj-1.5.3.2 from here: http://jcenter.bintray.com/org/asciidoctor/asciidoctorj/1.5.3.2/asciidoctorj-1.5.3.2-bin.zip
Go to the bin/ folder and execute (All on Windows certainly) |
I tried this on win7 without the fix and have no problems running the example. Did you happen to add a workaround to this version? |
I can reproduce the error with 1.7.23 and produces a pdf with 1.7.24-SNAPSHOT closing as fixed it with 6b115fa |
Thanks for fixing and verifying @mkristian! From the test case, it certainly looks like it covers the scenario. @robertpanzer Is there a test in AsciidoctorJ that can verify this fix? If not, we might want to add one just to be sure we catch any regressions, if they should occur. |
I added an integration test to asciidoctorj-distribution recently on the Am Mittwoch, 13. Januar 2016 schrieb Dan Allen :
|
👍 |
When rendering a document with asciidoctorj-pdf on Win7 rendering fails in the Addressable gem where a file is opened that is part of the gem and therefore packaged in a jar.
The error can be reproduced easily with this gradle build file running
gradle runTest
:Setting the jruby version to 1.7.21 makes the build pass.
The error I see is:
The text was updated successfully, but these errors were encountered: