fix warnings in Mojo::Cookie::Response

mojolicious · Nov 30, 2015 · c6d00ca · c6d00ca
1 parent 0ac5726
commit c6d00ca
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,6 @@
 
 6.35  2015-12-02
+  - Fixed warnings in Mojo::Cookie::Response.
 
 6.34  2015-12-01
   - Improved Hypnotoad to report problems that have occured during the creation

diff --git a/lib/Mojo/Cookie/Response.pm b/lib/Mojo/Cookie/Response.pm
@@ -20,7 +20,7 @@ sub parse {
     while (my ($name, $value) = splice @$pairs, 0, 2) {
       next unless $ATTRS{my $attr = lc $name};
       $value =~ s/^\.// if $attr eq 'domain';
-      $value = Mojo::Date->new($value)->epoch if $attr eq 'expires';
+      $value = Mojo::Date->new($value // '')->epoch if $attr eq 'expires';
       $value = 1 if $attr eq 'secure' || $attr eq 'httponly';
       $cookies[-1]{$attr eq 'max-age' ? 'max_age' : $attr} = $value;
     }

diff --git a/t/mojo/cookie.t b/t/mojo/cookie.t
@@ -374,12 +374,19 @@ is $cookies->[1], undef, 'no more cookies';
 
 # Parse response cookie with broken Expires value
 $cookies = Mojo::Cookie::Response->parse('foo="ba r"; Expires=Th');
-is $cookies->[0]->name,  'foo',  'right name';
-is $cookies->[0]->value, 'ba r', 'right value';
+is $cookies->[0]->name,    'foo',  'right name';
+is $cookies->[0]->value,   'ba r', 'right value';
+is $cookies->[0]->expires, undef,  'no expires value';
 is $cookies->[1], undef, 'no more cookies';
 $cookies = Mojo::Cookie::Response->parse('foo="ba r"; Expires=Th; Path=/test');
-is $cookies->[0]->name,  'foo',  'right name';
-is $cookies->[0]->value, 'ba r', 'right value';
+is $cookies->[0]->name,    'foo',  'right name';
+is $cookies->[0]->value,   'ba r', 'right value';
+is $cookies->[0]->expires, undef,  'no expires value';
+is $cookies->[1], undef, 'no more cookies';
+$cookies = Mojo::Cookie::Response->parse('foo="ba r"; Expires; Path=/test');
+is $cookies->[0]->name,    'foo',  'right name';
+is $cookies->[0]->value,   'ba r', 'right value';
+is $cookies->[0]->expires, undef,  'no expires value';
 is $cookies->[1], undef, 'no more cookies';
 
 # Response cookie with Max-Age 0 and Expires 0