Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

htmlParseEntityRef throws error for valid iframe src URLs #267

Closed
jackfrancis opened this issue Nov 15, 2015 · 3 comments
Closed

htmlParseEntityRef throws error for valid iframe src URLs #267

jackfrancis opened this issue Nov 15, 2015 · 3 comments
Assignees
@gjtorikian

Comments

@jackfrancis
Copy link

Using the check_html option, I can't seem to get htmlproof to accept an iframe src URL with more than 1 param (i.e., a src string that will have a literal & to delimit param names). E.g.:

  *  htmlParseEntityRef: expecting ';' (line 92)

The relevant line 92:

<iframe frameborder="0" style="border:0" src="https://www.google.com/maps/embed/v1/place?q=1035%20Market%20Street%2C%20Suite%20550%20San%20Francisco%2C%20CA%2094103&key=R-E-D-A-C-T-E-D"></iframe>

The above code is obviously valid (excepting the redacted key value), and comes straight from Google:

https://developers.google.com/maps/documentation/embed/start

In the interim, I am using the file_ignore option to get HTML validation on the rest of my site, but I would love to be able to validate the above code. Thanks!
@gjtorikian gjtorikian self-assigned this Nov 15, 2015
@Joshua-Anderson
Copy link

Seeing the same problem with this onClick attribute of a link:

onClick="window.open('https://calendar.google.com/calendar/embed?src=o3uckm13gkcc5tu4u3846ik0pc%40group.calendar.google.com&ctz=America/Los_Angeles','Team Calendar','')"

Changing the google calendar url to 'https://test.com' causes the proofer to pass

@gjtorikian gjtorikian mentioned this issue Nov 24, 2015
Merged
@bascht
Copy link

bascht commented Aug 22, 2017

@gjtorikian I might have found a regression of this one + #386:

<!-- will yield an error: *  822:87: ERROR: htmlParseEntityRef: expecting ';' (line x) -->
<script src="//maps.googleapis.com/maps/api/js?callback=boing&key=xyz"></script>

<!-- will pass: -->
<script src="https://maps.googleapis.com/maps/api/js?callback=boing&key=xyz"></script>

Should I open a new issue?

@gjtorikian
Copy link
Owner

@bascht Yes please!

@bascht bascht mentioned this issue Aug 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gjtorikian gjtorikian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bascht @gjtorikian @jackfrancis @Joshua-Anderson