[Truffle] Only respecialize on null storage for Array#<<.

jruby · Nov 25, 2015 · e69ca7e · e69ca7e
1 parent 8e4bd0e
commit e69ca7e
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/truffle/src/main/java/org/jruby/truffle/nodes/core/array/AppendOneNode.java b/truffle/src/main/java/org/jruby/truffle/nodes/core/array/AppendOneNode.java
@@ -35,30 +35,28 @@ public AppendOneNode(RubyContext context, SourceSection sourceSection) {
 
     // Append into an empty array
 
-    // TODO CS 12-May-15 differentiate between null and empty but possibly having enough space
-
-    @Specialization(guards = "isEmptyArray(array)")
+    @Specialization(guards = "isNullArray(array)")
     public DynamicObject appendOneEmpty(DynamicObject array, int value) {
         Layouts.ARRAY.setStore(array, new int[]{value});
         Layouts.ARRAY.setSize(array, 1);
         return array;
     }
 
-    @Specialization(guards = "isEmptyArray(array)")
+    @Specialization(guards = "isNullArray(array)")
     public DynamicObject appendOneEmpty(DynamicObject array, long value) {
         Layouts.ARRAY.setStore(array, new long[]{value});
         Layouts.ARRAY.setSize(array, 1);
         return array;
     }
 
-    @Specialization(guards = "isEmptyArray(array)")
+    @Specialization(guards = "isNullArray(array)")
     public DynamicObject appendOneEmpty(DynamicObject array, double value) {
         Layouts.ARRAY.setStore(array, new double[]{value});
         Layouts.ARRAY.setSize(array, 1);
         return array;
     }
 
-    @Specialization(guards = "isEmptyArray(array)")
+    @Specialization(guards = "isNullArray(array)")
     public DynamicObject appendOneEmpty(DynamicObject array, Object value) {
         Layouts.ARRAY.setStore(array, new Object[]{value});
         Layouts.ARRAY.setSize(array, 1);