forcing a nil (no) backtrace with Java APIs #3488
Merged
+86
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
changed the title
kares
force-pushed
the
force-backtrace-nil
branch
from
99e0d56 to
0a3b5cd
Compare
kares
added a commit
to jruby/jruby-openssl
that referenced
this pull request
Dec 17, 2015
…array) ... little more confusing than a `nil` but for now has todo (until jruby/jruby#3488)
…he backtrace as nil
…() lazy the `backtrace()` return value when doing `set_backtrace` was ignored anyway
…rror) which is slightly faster ... avoids an instanceof check + Ruby boolean wrapping
kares
force-pushed
the
force-backtrace-nil
branch
from
0a3b5cd to
53e70e9
Compare
|
the changes also slightly improved performance (when require 'hitimes'
def measure(count = 1_000)
Hitimes::Interval.measure do
count.times do
begin
raise RuntimeError.new
rescue RuntimeError => e
puts e.message if false
end
end
end
end
print "warmup: "
puts measure(200_000).inspect
print "......: "
puts measure(500_000).inspectBEFORE: AFTER: |
kares
added a commit
that referenced
this pull request
Jan 2, 2016
forcing a nil (no) backtrace with Java APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RaiseException(Ruby runtime, RubyClass type, String msg, IRubyObject backtrace, boolean native)constructor despite accepting anIRubyObjectbacktrace parameter (and not justRubyArray), passing a nil does not end up with theRubyException#backtracebeingnilbut rather an empty array which is not fortunate as in user-land its easy to dismiss and confusing.like to use the constructor for optional "lightweight" exception raising such as jruby/jruby-openssl#55
p.s. I'd like to consider backporting these changes to jruby-1_7 if there's no objections to that.