Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NormalizedFile should keep the uri part of the path as is #3487

Open
mkristian opened this issue Nov 23, 2015 · 1 comment
Open

NormalizedFile should keep the uri part of the path as is #3487

mkristian opened this issue Nov 23, 2015 · 1 comment

Comments

@mkristian
Copy link
Member

see more details here 5a7bd3f#commitcomment-14555449
@kares
Copy link
Member

kares commented Nov 23, 2015

wonder, if its needed much.
there's JRubyFile which has a static normalize helper - so the \\.sub logic is in multiple places. maybe if possible it should get @Deprecated ...

also NormalizedFile normalizes regardless of platform, which is "theoretically" not correct - my linux box allows me to have a \ in directory/file names, that is why JRubyFile's helper should be preferred.

kares added a commit that referenced this issue Dec 28, 2015
@kares
hide new NormalizedFile usage in RbConfig behind helpers (for potenti…
a3a7b91 
…al later change)

see #3487 (comment)
@mkristian mkristian mentioned this issue May 12, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkristian @kares