[Truffle] FindBugs.

jruby · Nov 24, 2015 · 2d487b9 · 2d487b9
1 parent 8183e2f
commit 2d487b9
Showing 2 changed files with 17 additions and 17 deletions.
diff --git a/truffle/src/main/java/org/jruby/truffle/om/dsl/processor/layout/LayoutParser.java b/truffle/src/main/java/org/jruby/truffle/om/dsl/processor/layout/LayoutParser.java
@@ -204,14 +204,14 @@ private void parseGetter(ExecutableElement methodElement) {
 
         // assert !(isFactoryGetter & isObjectTypeGetter);
 
-        if (isFactoryGetter) {
-            // assert methodElement.getParameters().get(0).getSimpleName().toString().equals("factory");
-        } else if (isObjectTypeGetter) {
-            // assert methodElement.getParameters().get(0).getSimpleName().toString().equals("objectType");
-        } else {
-            // assert methodElement.getParameters().get(0).asType().toString().equals(DynamicObject.class.getName());
-            // assert methodElement.getParameters().get(0).getSimpleName().toString().equals("object");
-        }
+        //if (isFactoryGetter) {
+        //     assert methodElement.getParameters().get(0).getSimpleName().toString().equals("factory");
+        //} else if (isObjectTypeGetter) {
+        //     assert methodElement.getParameters().get(0).getSimpleName().toString().equals("objectType");
+        //} else {
+        //     assert methodElement.getParameters().get(0).asType().toString().equals(DynamicObject.class.getName());
+        //     assert methodElement.getParameters().get(0).getSimpleName().toString().equals("object");
+        //}
 
         final String name = titleToCamel(methodElement.getSimpleName().toString().substring("get".length()));
         final PropertyBuilder property = getProperty(name);
@@ -236,12 +236,12 @@ private void parseSetter(ExecutableElement methodElement) {
 
         // assert !(isFactorySetter && isUnsafeSetter);
 
-        if (isFactorySetter) {
-            // assert methodElement.getParameters().get(0).getSimpleName().toString().equals("factory");
-        } else {
-            // assert methodElement.getParameters().get(0).asType().toString().equals(DynamicObject.class.getName());
-            // assert methodElement.getParameters().get(0).getSimpleName().toString().equals("object");
-        }
+        //if (isFactorySetter) {
+        //    assert methodElement.getParameters().get(0).getSimpleName().toString().equals("factory");
+        //} else {
+        //    assert methodElement.getParameters().get(0).asType().toString().equals(DynamicObject.class.getName());
+        //    assert methodElement.getParameters().get(0).getSimpleName().toString().equals("object");
+        //}
 
         String name = titleToCamel(methodElement.getSimpleName().toString().substring("set".length()));
 

diff --git a/truffle/src/main/java/org/jruby/truffle/om/dsl/processor/layout/model/PropertyModel.java b/truffle/src/main/java/org/jruby/truffle/om/dsl/processor/layout/model/PropertyModel.java
@@ -36,9 +36,9 @@ public PropertyModel(String name, boolean hasObjectTypeGetter, boolean hasFactor
         // assert name != null;
         // assert type != null;
 
-        if (hasFactoryGetter || hasFactorySetter || hasObjectTypeGetter) {
-            // assert isShapeProperty;
-        }
+        //if (hasFactoryGetter || hasFactorySetter || hasObjectTypeGetter) {
+        //    assert isShapeProperty;
+        //}
 
         // assert !(volatileSemantics && isShapeProperty);
         // assert !(volatileSemantics && hasUnsafeSetter);