Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 2fd7ee12d9ee
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 70cc9968f667
Choose a head ref
  • 3 commits
  • 4 files changed
  • 3 contributors

Commits on Aug 4, 2014

  1. timers: fix timers with non-integer delay hanging.

    When backporting f8193ab into v0.10, a regression was introduced. Timers
    with non-integer timeout could trigger a infinite recursion with 100%
    cpu usage. This commit backports 93b0624 which fixes the regression.
    
    After backporting f8193ab, instead of using Date.now(), timers would use
    Timer.now() to determine if they had expired. However, Timer.now() is
    based on loop->time, which is not updated when a timer's remaining time
    is > 0 and < 1. Timers would thus never timeout if their remaining time
    was at some point > 0 and < 1.
    
    With this commit, Timer.now() updates loop->time itself, and timers
    always timeout eventually.
    
    Fixes #8065 and #8068.
    Julien Gilli authored and tjfontaine committed Aug 4, 2014
    Copy the full SHA
    6f04394 View commit details
    Browse the repository at this point in the history
  2. v8: Fix compliation with GCC 4.8

    Supresses a very loud warning from GCC 4.8 about unused typedefs
    
    Original url https://codereview.chromium.org/69413002
    tjfontaine committed Aug 4, 2014
    1
    Copy the full SHA
    53b4acc View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2014

  1. Copy the full SHA
    70cc996 View commit details
    Browse the repository at this point in the history