Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Abort compile when attempting to build client with Irrlicht 1.8.2
- Loading branch information
Showing
1 changed file
with
13 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
889f893
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 ;^)
889f893
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please test the other way round (
IRRLICHT_VERSION_REVISION == 2
first, …), l guess 1.8.* often appears but * .*.2 seldom appears.889f893
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider that less readable. The way @kwolekr did it was completely okay.
889f893
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And don't overcomplicate version recognition #ifdefs, after all a broken ifdef version recognition is why 1.8.2 is a broken release.