remove all Problems from fcrepo-kernel-api #947
Conversation
| @@ -47,6 +47,10 @@ | |||
| <artifactId>javax.inject</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.modeshape</groupId> | |||
There was a problem hiding this comment.
Do you see what requires org.modeshape in the fcrepo-jms module? It seems like that is the next target.
There was a problem hiding this comment.
Yes, it is the JCR_CONTENT constant. It implies a deeper investigation as to why it is escaping the fcrepo-kernel-modeshape module. And yes, it is most certainly a good "next target".
There was a problem hiding this comment.
Also, I suspect that finding where the JCR_CONTENT value is escaping from fcrepo-kernel-modeshape will also help remove that from fcrepo-module-auth-webac: http://git.io/v854c
|
@ajs6f updated PR with your suggestions |
| return repoMgr.backupRepository(backupDirectory); | ||
| final Collection<Throwable> problems = new ArrayList<>(); | ||
|
|
||
| repoMgr.backupRepository(backupDirectory).forEach(x -> { |
There was a problem hiding this comment.
No need for braces and newlines here, just .backupRepository(backupDirectory).forEach(x -> problems.add(x.getThrowable()));
|
Resolved with: 89b8bff |
Resolves: https://jira.duraspace.org/browse/FCREPO-1834