Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: aab126bb0604
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 37c2a528336b
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Aug 2, 2014

  1. path: fix slice OOB in trim 

    Internal function trim(arr). 2nd parameter of slice() should be slice's
end index (not included). Because of function normalize() (called before
trim()), "start" is always zero so the bug -for now- has no effect, but
its a bug waiting to happen.

Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    @luciotato @trevnorris
    luciotato authored and trevnorris committed Aug 2, 2014
    Copy the full SHA
    37c2a52 View commit details
    Browse the repository at this point in the history