better WebSocket frame tests

mojolicious · May 4, 2012 · 6ff17ab · 6ff17ab
1 parent 5b4f1d0
commit 6ff17ab
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 13 deletions.
diff --git a/Changes b/Changes
@@ -1,6 +1,6 @@
 This file documents the revision history for Perl extension Mojolicious.
 
-2.93  2012-05-04
+2.93  2012-05-05
   - Added remove method to Mojolicious::Routes::Route.
   - Improved 32bit Perl support of Mojo::Transaction::WebSocket.
     (mikemagowan, sri)

diff --git a/t/mojo/websocket_frames.t b/t/mojo/websocket_frames.t
@@ -2,13 +2,14 @@ use Mojo::Base -strict;
 
 # "Being eaten by crocodile is just like going to sleep...
 #  in a giant blender."
-use Test::More tests => 105;
+use Test::More tests => 117;
 
 use Mojo::Transaction::WebSocket;
 
 # Simple text frame roundtrip
-my $ws    = Mojo::Transaction::WebSocket->new;
+my $ws = Mojo::Transaction::WebSocket->new;
 my $bytes = $ws->build_frame(1, 0, 0, 0, 1, 'whatever');
+is $bytes, "\x81\x08\x77\x68\x61\x74\x65\x76\x65\x72", 'right frame';
 my $frame = $ws->parse_frame(\(my $dummy = $bytes));
 is $frame->[0], 1,          'fin flag is set';
 is $frame->[1], 0,          'rsv1 flag is not set';
@@ -19,8 +20,9 @@ is $frame->[5], 'whatever', 'right payload';
 is $ws->build_frame(1, 0, 0, 0, 1, 'whatever'), $bytes, 'frames are equal';
 
 # Simple text frame roundtrip with all flags set
-$ws    = Mojo::Transaction::WebSocket->new;
+$ws = Mojo::Transaction::WebSocket->new;
 $bytes = $ws->build_frame(1, 1, 1, 1, 1, 'whatever');
+is $bytes, "\xf1\x08\x77\x68\x61\x74\x65\x76\x65\x72", 'right frame';
 $frame = $ws->parse_frame(\($dummy = $bytes));
 is $frame->[0], 1,          'fin flag is set';
 is $frame->[1], 1,          'rsv1 flag is set';
@@ -31,8 +33,9 @@ is $frame->[5], 'whatever', 'right payload';
 is $ws->build_frame(1, 1, 1, 1, 1, 'whatever'), $bytes, 'frames are equal';
 
 # Simple text frame roundtrip with RSV1 flags set
-$ws    = Mojo::Transaction::WebSocket->new;
+$ws = Mojo::Transaction::WebSocket->new;
 $bytes = $ws->build_frame(1, 1, 0, 0, 1, 'whatever');
+is $bytes, "\xc1\x08\x77\x68\x61\x74\x65\x76\x65\x72", 'right frame';
 $frame = $ws->parse_frame(\($dummy = $bytes));
 is $frame->[0], 1,          'fin flag is set';
 is $frame->[1], 1,          'rsv1 flag is set';
@@ -43,8 +46,9 @@ is $frame->[5], 'whatever', 'right payload';
 is $ws->build_frame(1, 1, 0, 0, 1, 'whatever'), $bytes, 'frames are equal';
 
 # Simple text frame roundtrip with RSV2 flags set
-$ws    = Mojo::Transaction::WebSocket->new;
+$ws = Mojo::Transaction::WebSocket->new;
 $bytes = $ws->build_frame(1, 0, 1, 0, 1, 'whatever');
+is $bytes, "\xa1\x08\x77\x68\x61\x74\x65\x76\x65\x72", 'right frame';
 $frame = $ws->parse_frame(\($dummy = $bytes));
 is $frame->[0], 1,          'fin flag is set';
 is $frame->[1], 0,          'rsv1 flag is not set';
@@ -55,8 +59,9 @@ is $frame->[5], 'whatever', 'right payload';
 is $ws->build_frame(1, 0, 1, 0, 1, 'whatever'), $bytes, 'frames are equal';
 
 # Simple text frame roundtrip with RSV3 flags set
-$ws    = Mojo::Transaction::WebSocket->new;
+$ws = Mojo::Transaction::WebSocket->new;
 $bytes = $ws->build_frame(1, 0, 0, 1, 1, 'whatever');
+is $bytes, "\x91\x08\x77\x68\x61\x74\x65\x76\x65\x72", 'right frame';
 $frame = $ws->parse_frame(\($dummy = $bytes));
 is $frame->[0], 1,          'fin flag is set';
 is $frame->[1], 0,          'rsv1 flag is not set';
@@ -67,8 +72,9 @@ is $frame->[5], 'whatever', 'right payload';
 is $ws->build_frame(1, 0, 0, 1, 1, 'whatever'), $bytes, 'frames are equal';
 
 # Simple binary frame roundtrip
-$ws    = Mojo::Transaction::WebSocket->new;
+$ws = Mojo::Transaction::WebSocket->new;
 $bytes = $ws->build_frame(1, 0, 0, 0, 2, 'works');
+is $bytes, "\x82\x05\x77\x6f\x72\x6b\x73", 'right frame';
 $frame = $ws->parse_frame(\($dummy = $bytes));
 is $frame->[0], 1,       'fin flag is set';
 is $frame->[1], 0,       'rsv1 flag is not set';
@@ -112,8 +118,9 @@ isnt(
 );
 
 # One-character text frame roundtrip
-$ws    = Mojo::Transaction::WebSocket->new;
+$ws = Mojo::Transaction::WebSocket->new;
 $bytes = $ws->build_frame(1, 0, 0, 0, 1, 'a');
+is $bytes, "\x81\x01\x61", 'right frame';
 $frame = $ws->parse_frame(\($dummy = $bytes));
 is $frame->[0], 1,   'fin flag is set';
 is $frame->[1], 0,   'rsv1 flag is not set';
@@ -124,8 +131,9 @@ is $frame->[5], 'a', 'right payload';
 is $ws->build_frame(1, 0, 0, 0, 1, 'a'), $bytes, 'frames are equal';
 
 # One-byte binary frame roundtrip
-$ws    = Mojo::Transaction::WebSocket->new;
+$ws = Mojo::Transaction::WebSocket->new;
 $bytes = $ws->build_frame(1, 0, 0, 0, 2, 'a');
+is $bytes, "\x82\x01\x61", 'right frame';
 $frame = $ws->parse_frame(\($dummy = $bytes));
 is $frame->[0], 1,   'fin flag is set';
 is $frame->[1], 0,   'rsv1 flag is not set';
@@ -136,8 +144,9 @@ is $frame->[5], 'a', 'right payload';
 is $bytes = $ws->build_frame(1, 0, 0, 0, 2, 'a'), $bytes, 'frames are equal';
 
 # 16bit text frame roundtrip
-$ws    = Mojo::Transaction::WebSocket->new;
+$ws = Mojo::Transaction::WebSocket->new;
 $bytes = $ws->build_frame(1, 0, 0, 0, 1, 'hi' x 10000);
+is $bytes, "\x81\x7e\x4e\x20" . ("\x68\x69" x 10000), 'right frame';
 $frame = $ws->parse_frame(\($dummy = $bytes));
 is $frame->[0], 1, 'fin flag is set';
 is $frame->[1], 0, 'rsv1 flag is not set';
@@ -150,6 +159,8 @@ is $ws->build_frame(1, 0, 0, 0, 1, 'hi' x 10000), $bytes, 'frames are equal';
 # 64bit text frame roundtrip
 $ws = Mojo::Transaction::WebSocket->new(max_websocket_size => 500000);
 $bytes = $ws->build_frame(1, 0, 0, 0, 1, 'hi' x 200000);
+is $bytes, "\x81\x7f\x00\x00\x00\x00\x00\x06\x1a\x80" . ("\x68\x69" x 200000),
+  'right frame';
 $frame = $ws->parse_frame(\($dummy = $bytes));
 is $frame->[0], 1, 'fin flag is set';
 is $frame->[1], 0, 'rsv1 flag is not set';
@@ -160,8 +171,9 @@ is $frame->[5], 'hi' x 200000, 'right payload';
 is $ws->build_frame(1, 0, 0, 0, 1, 'hi' x 200000), $bytes, 'frames are equal';
 
 # Empty text frame roundtrip
-$ws    = Mojo::Transaction::WebSocket->new;
+$ws = Mojo::Transaction::WebSocket->new;
 $bytes = $ws->build_frame(1, 0, 0, 0, 1, '');
+is $bytes, "\x81\x00", 'right frame';
 $frame = $ws->parse_frame(\($dummy = $bytes));
 is $frame->[0], 1,  'fin flag is set';
 is $frame->[1], 0,  'rsv1 flag is not set';
@@ -172,8 +184,9 @@ is $frame->[5], '', 'no payload';
 is $ws->build_frame(1, 0, 0, 0, 1, ''), $bytes, 'frames are equal';
 
 # Empty close frame roundtrip
-$ws    = Mojo::Transaction::WebSocket->new;
+$ws = Mojo::Transaction::WebSocket->new;
 $bytes = $ws->build_frame(1, 0, 0, 0, 8, '');
+is $bytes, "\x88\x00", 'right frame';
 $frame = $ws->parse_frame(\($dummy = $bytes));
 is $frame->[0], 1,  'fin flag is set';
 is $frame->[1], 0,  'rsv1 flag is not set';