Range content retrieval with javax.jcr.Binary to improve performance. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| builder = status(PARTIAL_CONTENT).entity(rangeInputStream) | ||
| .header("Content-Range", contentRangeValue); | ||
| final long maxBufferSize = 10240000; // 10MB max buffer size? |
There was a problem hiding this comment.
Please add a unit test to FedoraContentTest.java to provide test coverage for this new logic in ContentExposingResource.java.
through skip bytes with the static setter for max buffer.
|
Resolved with: 4da6bb1 Addresses: https://www.pivotaltracker.com/story/show/71429770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/s/projects/684825/stories/71429770
Added Binary.read(byte[] b, int position) for range content retrieval, with range content size limitation to balance the memory usage.