slim down comments; tweak final test for reshape/setdims fix (bug 403)

PDLPorters · Nov 13, 2015 · eba0d9a · eba0d9a
1 parent 6cb8029
commit eba0d9a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/Basic/Core/Core.xs b/Basic/Core/Core.xs
@@ -1210,7 +1210,7 @@ setdims(x,dims_arg)
 	CODE:
 	{
 	        /* This mask avoids all kinds of subtle dereferencing bugs (CED 11/2015) */
-		if(x->trans || x->vafftrans || x->children.next){
+	        if(x->trans || x->vafftrans || x->children.next ) {
 		  pdl_barf("Can't setdims on a PDL that already has children");
 		}
 

diff --git a/t/core.t b/t/core.t
@@ -13,7 +13,7 @@ BEGIN {
     eval {
         require PDL::LiteF;
     } or BAIL_OUT("PDL::LiteF failed: $@");
-    plan tests => 67;
+    plan tests => 66;
     PDL::LiteF->import;
 }
 $| = 1;
@@ -242,9 +242,6 @@ ok( ( $a->ndims==2 and $a->dim(0)==2 and $a->dim(1)==2 ), "reshape did the right
 ok(all($a == short pdl([[3,4],[5,6]])), "reshape moved the elements to the right place");
 
 $b = $a->slice(":,:");
-eval { $a->reshape(4); };
-ok( $@ =~ m/Can\'t/, "reshape fails on a PDL with a child" );
-
 eval { $b->reshape(4); };
-ok($@ =~ m/Can\'t/, "reshape fails on a PDL with a parent" );
+ok( $@ =~ m/Can\'t/, "reshape fails on a PDL with a parent" );