You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fix for the reshape bug was to enforce the fact that reshape doesn't work for piddles with dataflow. In trying to install PDL::Stats onto a PDL-2.014_01 setup, I implemented the same work-around for the problem as reported by kmx.
However, I grepped for reshape in the source code and found a number of other places where there could potentially be a problem. It looks like all the reshape() usages are either on a piddle that has already been sever()'d (so no dataflow) or the resulting piddle after the reshape() is immediately sever()'d so moving the ->sever before the ->reshape() from after should work in all these cases as well.
I didn't read through the full code but it seems likely that the fix should be applied.
The text was updated successfully, but these errors were encountered:
The fix for the reshape bug was to enforce the fact that reshape doesn't
work for piddles with dataflow. In trying to install PDL::Stats onto a
PDL-2.014_01 setup, I implemented the same work-around for the problem as
reported by kmx.
However, I grepped for reshape in the source code and found a number of
other places where there could potentially be a problem. It looks like all
the reshape() usages are either on a piddle that has already been sever()'d
(so no dataflow) or the resulting piddle after the reshape() is immediately
sever()'d so moving the ->sever before the ->reshape() from after should
work in all these cases as well.
I didn't read through the full code but it seems likely that the fix
should be applied.
—
Reply to this email directly or view it on GitHub #23.
With PDL-2.014_01PDL-Stats-0.73 fails during make test with error Can't setdims on a PDL that already has children. But he latest github master version is OK - it was fixed by 78d7905 . However there might be another places.
The fix for the reshape bug was to enforce the fact that reshape doesn't work for piddles with dataflow. In trying to install PDL::Stats onto a PDL-2.014_01 setup, I implemented the same work-around for the problem as reported by kmx.
However, I grepped for reshape in the source code and found a number of other places where there could potentially be a problem. It looks like all the reshape() usages are either on a piddle that has already been sever()'d (so no dataflow) or the resulting piddle after the reshape() is immediately sever()'d so moving the ->sever before the ->reshape() from after should work in all these cases as well.
I didn't read through the full code but it seems likely that the fix should be applied.
The text was updated successfully, but these errors were encountered: