Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue with reshape() usage for PDL-2.014 and higher #23

Closed
devel-chm opened this issue Nov 15, 2015 · 3 comments
Closed

Possible issue with reshape() usage for PDL-2.014 and higher #23

devel-chm opened this issue Nov 15, 2015 · 3 comments

Comments

@devel-chm
Copy link
Member

The fix for the reshape bug was to enforce the fact that reshape doesn't work for piddles with dataflow. In trying to install PDL::Stats onto a PDL-2.014_01 setup, I implemented the same work-around for the problem as reported by kmx.

However, I grepped for reshape in the source code and found a number of other places where there could potentially be a problem. It looks like all the reshape() usages are either on a piddle that has already been sever()'d (so no dataflow) or the resulting piddle after the reshape() is immediately sever()'d so moving the ->sever before the ->reshape() from after should work in all these cases as well.

I didn't read through the full code but it seems likely that the fix should be applied.

@maggiexyz
Copy link
Contributor

Thanks for noting this! I'll take a look next weekend.

On Sun, Nov 15, 2015 at 1:28 PM, devel-chm notifications@github.com wrote:

The fix for the reshape bug was to enforce the fact that reshape doesn't
work for piddles with dataflow. In trying to install PDL::Stats onto a
PDL-2.014_01 setup, I implemented the same work-around for the problem as
reported by kmx.

However, I grepped for reshape in the source code and found a number of
other places where there could potentially be a problem. It looks like all
the reshape() usages are either on a piddle that has already been sever()'d
(so no dataflow) or the resulting piddle after the reshape() is immediately
sever()'d so moving the ->sever before the ->reshape() from after should
work in all these cases as well.

I didn't read through the full code but it seems likely that the fix
should be applied.


Reply to this email directly or view it on GitHub
#23.

@kmx
Copy link
Contributor

kmx commented Nov 16, 2015

With PDL-2.014_01 PDL-Stats-0.73 fails during make test with error Can't setdims on a PDL that already has children. But he latest github master version is OK - it was fixed by 78d7905 . However there might be another places.

Maybe it is time for PDL-Stats-0.74

@mohawk2
Copy link
Member

mohawk2 commented Apr 19, 2021

Closing this. If it becomes a problem, please reopen.

@mohawk2 mohawk2 closed this as completed Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants