Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unicode_normalize specs #3526

Merged
merged 8 commits into from
Nov 22, 2015
Merged

Add unicode_normalize specs #3526

merged 8 commits into from
Nov 22, 2015
+117 −0

Conversation

jsyeo
Copy link
Member

@jsyeo jsyeo commented Nov 21, 2015

For #3264.

yorickpeterse
yorickpeterse reviewed Nov 21, 2015
View reviewed changes
spec/ruby/core/string/unicode_normalize_spec.rb
end

it "raises an Encoding::CompatibilityError if the string is not in an unicode encoding" do
lambda { @angstrom.force_encoding("ISO-8859-1").unicode_normalize }.should raise_error(Encoding::CompatibilityError)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you wrap this line at ~80 characters per line?

@yorickpeterse yorickpeterse self-assigned this Nov 21, 2015
@jsyeo
Copy link
Member Author

jsyeo commented Nov 21, 2015

@yorickpeterse I've updated the PR.

@yorickpeterse yorickpeterse merged commit 649739c into rubinius:2.2 Nov 22, 2015
@yorickpeterse
Copy link
Contributor

Thanks!

@jsyeo jsyeo deleted the jsyeo-unicode-normalize-specs branch January 4, 2016 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yorickpeterse yorickpeterse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsyeo @yorickpeterse