fix handling of invalid URLs in Mojo::UserAgent::CookieJar

mojolicious · Nov 13, 2015 · 08d5f42 · 08d5f42
1 parent 72d0bc1
commit 08d5f42
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/Changes b/Changes
@@ -1,5 +1,6 @@
 
 6.31  2015-11-13
+  - Fixed handling of invalid URLs in Mojo::UserAgent::CookieJar.
   - Fixed a few small selector bugs in Mojo::DOM::CSS.
 
 6.30  2015-11-11

diff --git a/lib/Mojo/UserAgent/CookieJar.pm b/lib/Mojo/UserAgent/CookieJar.pm
@@ -100,7 +100,7 @@ sub find {
   }
 
   # Remove another part
-  continue { $domain =~ s/^[^.]+\.?// }
+  continue { $domain =~ s/^[^.]+\.*// }
 
   return \@found;
 }

diff --git a/t/mojo/cookiejar.t b/t/mojo/cookiejar.t
@@ -255,6 +255,10 @@ $tx = Mojo::Transaction::HTTP->new;
 $tx->req->url->parse('http://mojolicio.us/whatever');
 $jar->prepare($tx);
 is $tx->req->cookie('foo'), undef, 'no cookie';
+$tx = Mojo::Transaction::HTTP->new;
+$tx->req->url->parse('http://manydots...');
+$jar->prepare($tx);
+is $tx->req->cookie('foo'), undef, 'no cookie';
 
 # Gather and prepare cookies with same name (with and without domain)
 $jar = Mojo::UserAgent::CookieJar->new;