Include zlib linker flag if not building with the vendored one #3524
Conversation
|
I restarted the OS X builds as they failed due to what appears to be an unrelated RubyGems/Ruby issue. Will check back again tomorrow to see the results. |
|
For some bizarre reason the build keeps failing on OS X when running |
|
Looks like Ruby 2.0.0-p576 and RubyGems 2.5.0 are a bad combo on OS X, I think subsequent OS X builds will fail for the same reason. Can we bump Ruby version a little? |
|
Sorry, no idea about OS X issues - I only build on linux. |
|
@ahmadsherif Bumping it to 2.2 should be fine, you're free to add this to this PR if you'd like (that way we can immediately see if it actually works). |
OS X builds started to fail after the release of RubyGems 2.5.0, so this should fix it.
Apparently building with LLVM enabled includes this flag, probably because of using `--system-libs`, so building without LLVM fails because it can't link against zlib.
ahmadsherif
force-pushed
the
fix/build-with-llvm-disabled
branch
from
9d00a73
to
b9ca4b3
Compare
|
@yorickpeterse All passing except for the clang/linux job, which fails for the same reason as the clang/osx job from the last master build. |
|
@ahmadsherif Restarted build, it's green now. Thanks! |
Apparently building with LLVM enabled includes this flag, probably because of using
--system-libs, so building without LLVM fails because it can't link against zlib.