no need to use a capturing group

mojolicious · Nov 18, 2015 · 8761a8f · 8761a8f
1 parent c9b6598
commit 8761a8f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/Mojolicious/Guides/Routing.pod b/lib/Mojolicious/Guides/Routing.pod
@@ -787,10 +787,10 @@ to list all available routes together with name and underlying regular
 expressions.
 
   $ ./myapp.pl routes -v
-  /foo/:name  ....  POST  fooname  (^\/foo/([^/.]+)/?(?:\.([^/]+))?$)
-  /bar        ..U.  *     bar      (^\/bar)
-    +/baz     ...W  GET   baz      (^\/baz/?(?:\.([^/]+))?$)
-  /yada       ....  *     yada     (^\/yada/?(?:\.([^/]+))?$)
+  /foo/:name  ....  POST  fooname  ^\/foo/([^/.]+)/?(?:\.([^/]+))?$
+  /bar        ..U.  *     bar      ^\/bar
+    +/baz     ...W  GET   baz      ^\/baz/?(?:\.([^/]+))?$
+  /yada       ....  *     yada     ^\/yada/?(?:\.([^/]+))?$
 
 =head1 ADVANCED
 

diff --git a/lib/Mojolicious/Routes/Pattern.pm b/lib/Mojolicious/Routes/Pattern.pm
@@ -33,7 +33,7 @@ sub match_partial {
   # Path
   return undef unless my @captures = $$pathref =~ $self->regex;
   $$pathref = ${^POSTMATCH};
-  shift @captures;
+  @captures = () if $#+ == 0;
   my $captures = {%{$self->defaults}};
   for my $placeholder (@{$self->placeholders}, 'format') {
     last unless @captures;
@@ -142,7 +142,7 @@ sub _compile {
   $regex .= _compile_format($constraints->{format}, $defaults->{format})
     if $detect;
 
-  $self->regex(qr/(^$regex)/ps);
+  $self->regex(qr/^$regex/ps);
 }
 
 sub _compile_format {